PHILO-HE commented on code in PR #11384: URL: https://github.com/apache/incubator-gluten/pull/11384#discussion_r2674884288
########## tools/workload/tpcds/gen_data/parquet_dataset/tpcds_datagen_parquet.scala: ########## @@ -22,7 +22,13 @@ val numPartitions = 200 // how many dsdgen partitions to run - number of input val format = "parquet" // valid spark format like parquet "parquet". val rootDir = "/PATH/TO/TPCDS_PARQUET_PATH" // root directory of location to create data in. -val dsdgenDir = "/PATH/TO/TPCDS_DBGEN" // location of dbgen + +/** + * Location of dbgen. + * Please compile with https://github.com/databricks/tpcds-kit.git. + * See https://github.com/databricks/spark-sql-perf/issues/126. Review Comment: It seems unnecessary since the correct tpcds-kit has been provided. If you still want to include it, it would be better to add a comment to clarify what this link is, e.g., `Other tpcds-kit may cause errors, see discussion: https://github.com/databricks/spark-sql-perf/issues/126` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
