Surbhi-Vijay commented on code in PR #11387:
URL:
https://github.com/apache/incubator-gluten/pull/11387#discussion_r2681245488
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/ValidatablePlan.scala:
##########
@@ -85,6 +85,12 @@ trait ValidatablePlan extends GlutenPlan with LogLevelUtil {
s" consider enabling the spark.sql.legacy.allowHashOnMapType " +
s"setting to resolve this issue."
ValidationResult.failed(message)
+ case e: IllegalArgumentException =>
+ // SchemaValidation throws IllegalArgumentException in Join
validation
+ // when join type is unsupported. For example,
+ // LeftSingle join in BroadcastHashJoinExecTransformer.
+ ValidationResult.failed(
+ s"Failed to retrieve schema for ${this.nodeName}, due to:
${e.getMessage}")
}
Review Comment:
I think it should be okay to check `IllegalArgumentException`. We are
catching this exception during validation phase and even if the validation is
failing at some other place than joins, it should fallback to Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
