liujiayi771 commented on code in PR #11429:
URL:
https://github.com/apache/incubator-gluten/pull/11429#discussion_r2703177220
##########
cpp/CMakeLists.txt:
##########
@@ -147,7 +147,8 @@ if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
add_compile_definitions(_GNU_SOURCE)
endif()
-if(NOT ${CMAKE_SYSTEM_NAME} STREQUAL "Darwin")
+if(NOT "${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin" AND "${CMAKE_CXX_COMPILER_ID}"
Review Comment:
@PHILO-HE Yes, I’ve also considered removing this part before. The "Darwin"
check here was likely added because macOS defaults to Clang, which caused some
compilation failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
