PHILO-HE commented on code in PR #11444:
URL:
https://github.com/apache/incubator-gluten/pull/11444#discussion_r2706844920
##########
dev/vcpkg/triplets/x64-linux-avx.cmake:
##########
@@ -13,3 +13,7 @@ set(VCPKG_LINKER_FLAGS "-static-libstdc++ -static-libgcc")
if("${PORT}" STREQUAL "snappy")
list(APPEND VCPKG_CMAKE_CONFIGURE_OPTIONS -DSNAPPY_HAVE_BMI2=ON)
endif()
+
+if(PORT STREQUAL "openssl")
+ set(VCPKG_LIBRARY_LINKAGE dynamic)
Review Comment:
Can we use dynamic link only when FIPS is enabled?
My understanding is that FIPS is not a requirement for many users. Then, the
current static link for openssl may be good for them.
##########
.github/workflows/velox_backend_x86.yml:
##########
@@ -67,8 +67,8 @@ jobs:
ccache-centos7-release-default
- name: Build Gluten native libraries
run: |
- docker pull apache/gluten:vcpkg-centos-7
- docker run -v $GITHUB_WORKSPACE:/work -w /work
apache/gluten:vcpkg-centos-7 bash -c "
+ docker pull apache/gluten:vcpkg-centos-9
Review Comment:
Suggest setting container field with centos 9 image, which is a standard
way. I assume it's compatible with GHA checkout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
