xumanbu commented on PR #11457:
URL:
https://github.com/apache/incubator-gluten/pull/11457#issuecomment-3789928164
> `dev/build-helper-functions.sh` seems duplicated with Velox - could we use
the one in Velox repo?
gluten have specific functions like setup_macos/setup_linux that aren't in
Velox's version, and velox's get_cxx_flags returns only base flags (e.g.,
-mcpu=neoverse-n1) without these additional flags.
they don't look exactly the same, I think it is better to remain independent
at now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
