rui-mo commented on code in PR #11392:
URL:
https://github.com/apache/incubator-gluten/pull/11392#discussion_r2764778529
##########
backends-velox/src/main/scala/org/apache/gluten/metrics/HashAggregateMetricsUpdater.scala:
##########
@@ -82,6 +83,7 @@ class HashAggregateMetricsUpdaterImpl(val metrics:
Map[String, SQLMetric])
aggSpilledFiles += aggMetrics.spilledFiles
flushRowCount += aggMetrics.flushRowCount
loadedToValueHook += aggMetrics.loadedToValueHook
+ bloomFilterBlocksByteSize += aggMetrics.bloomFilterBlocksByteSize
Review Comment:
It seems like the bloom filter pushdown in aggregate hasn’t been confirmed
to actually take effect yet, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]