wecharyu opened a new issue, #11635:
URL: https://github.com/apache/incubator-gluten/issues/11635

   ### Description
   
   https://github.com/apache/incubator-gluten/pull/9026 adds 
`ColumnarPartialProject` when the parent is also columnar, but it should be 
added when the parent supports partial fallback. Here is a simple example with 
nested `ProjectExec`:
   ```sql
   select plus_one(col1) as col2, l_partkey from (
     select plus_one(l_orderkey) as col1, l_partkey from lineitem
   )
   ```
   ```bash
   == Physical Plan ==
   *(1) Project [if (isnull(col1#73L)) null else 
plus_one(knownnotnull(col1#73L)) AS col2#74L, l_partkey#1L]
   +- *(1) Project [if (isnull(l_orderkey#0L)) null else 
plus_one(knownnotnull(l_orderkey#0L)) AS col1#73L, l_partkey#1L]
      +- VeloxColumnarToRow
         +- ^(1) BatchScanExecTransformer parquet 
file:/root/workspace/gluten-community/backends-velox/target/scala-2.13/test-classes/tpch-data-parquet/lineitem[l_orderkey#0L,
 l_partkey#1L] ParquetScan DataFilters: [], Format: parquet, Location: 
InMemoryFileIndex(1 
paths)[file:/root/workspace/gluten-community/backends-velox/target/scala-2.13...,
 PartitionFilters: [], PushedAggregation: [], PushedFilters: [], PushedGroupBy: 
[], ReadSchema: struct<l_orderkey:bigint,l_partkey:bigint> RuntimeFilters: [] 
NativeFilters: []
   ```
   
   There is a full C2R fallback even if the two `ProjectExec` supports partial 
projection.
   
   ### Gluten version
   
   main branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to