jinchengchenghh commented on PR #11566:
URL: 
https://github.com/apache/incubator-gluten/pull/11566#issuecomment-3951969941

   I try to add a unit test
   ```
     test("to_pretty_string") {
       val df = spark.sql("SELECT isnull(1)")
       df.show()
       print("plan is " + df.queryExecution.executedPlan.toString())
       checkGlutenPlan[ProjectExecTransformer](df)
     }
   ```
   +-----------+
   |(1 IS NULL)|
   +-----------+
   |      false|
   +-----------+
   
   plan is VeloxColumnarToRow
   +- ^(1) ProjectExecTransformer [isnull(1) AS (1 IS NULL)#146]
      +- ^(1) InputIteratorTransformer[]
         +- RowToVeloxColumnar
            +- *(1) Scan OneRowRelation[]
   
   But the plan does not contain the to_pretty_string, so it is hard to verify 
if it is really offload to native unless we can check the native plan.
   
   But ToPrettyString is really offloaded since the unit test getRows::binary 
failed with this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to