acvictor commented on code in PR #11657:
URL:
https://github.com/apache/incubator-gluten/pull/11657#discussion_r2888190657
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxMetricsApi.scala:
##########
@@ -628,6 +628,12 @@ class VeloxMetricsApi extends MetricsApi with Logging {
"hashProbeDynamicFiltersProduced" -> SQLMetrics.createMetric(
sparkContext,
"number of hash probe dynamic filters produced"),
+ "valueStreamDynamicFiltersAccepted" -> SQLMetrics.createMetric(
+ sparkContext,
+ "number of dynamic filters accepted by value stream"),
+ "valueStreamDynamicFilteredRows" -> SQLMetrics.createMetric(
+ sparkContext,
+ "number of rows filtered by value stream dynamic filter"),
Review Comment:
```
# Create a probe table (large) and a build table (selective) so the filter
has rows to prune
spark.sql("CREATE TABLE vs_probe_table USING PARQUET AS SELECT id AS a FROM
range(1000000)")
spark.sql("CREATE TABLE vs_build_table USING PARQUET AS SELECT id * 1000 AS
b FROM range(1000)")
# Push a dynamic filter
spark.sql("SELECT a FROM vs_probe_table JOIN vs_build_table ON a =
b").collect()
```
<img width="1258" height="875" alt="image"
src="https://github.com/user-attachments/assets/d43e515d-edec-4f03-a6e5-257e604e8763";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
