PHILO-HE commented on code in PR #11687:
URL:
https://github.com/apache/incubator-gluten/pull/11687#discussion_r2890396871
##########
gluten-substrait/src/main/scala/org/apache/spark/shuffle/GlutenShuffleUtils.scala:
##########
@@ -18,10 +18,9 @@ package org.apache.spark.shuffle
import org.apache.gluten.backendsapi.BackendsApiManager
import org.apache.gluten.config.GlutenConfig
-import org.apache.gluten.sql.shims.SparkShimLoader
import org.apache.gluten.vectorized.NativePartitioning
-import org.apache.spark.{SparkConf, TaskContext}
+import org.apache.spark.{ShuffleUtils, SparkConf, TaskContext}
Review Comment:
Yes, it also exists in shims/spark33.
##########
backends-velox/src/main/scala/org/apache/gluten/extension/ArrowConvertorRule.scala:
##########
@@ -112,7 +112,9 @@ case class ArrowConvertorRule(session: SparkSession)
extends Rule[LogicalPlan] {
csvOptions.nullValue == "" &&
csvOptions.emptyValueInRead == "" && csvOptions.comment == '\u0000' &&
csvOptions.columnPruning &&
-
SparkShimLoader.getSparkShims.dateTimestampFormatInReadIsDefaultValue(csvOptions,
timeZone)
+ csvOptions.dateFormatInRead == default.dateFormatInRead &&
+ csvOptions.timestampFormatInRead == default.timestampFormatInRead &&
+ csvOptions.timestampNTZFormatInRead == default.timestampNTZFormatInRead
Review Comment:
Just confirmed in source code. It exists. And the compilation also help
ensures this. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
