Yizhou-Yang commented on code in PR #11651:
URL:
https://github.com/apache/incubator-gluten/pull/11651#discussion_r2903512762
##########
cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc:
##########
@@ -60,7 +60,7 @@ const std::unordered_set<std::string> kRegexFunctions = {
"split"};
const std::unordered_set<std::string> kBlackList =
- {"split_part", "sequence", "approx_percentile", "map_from_arrays"};
+ {"split_part", "sequence", "map_from_arrays"};
Review Comment:
sure, I will look into it. @jinchengchenghh
https://github.com/facebookincubator/velox/pull/13183
I think that the velox part is compatible with spark in 2025/05, it's just
for some reason the velox spark fix is not adopted in gluten. Right now I
think the only gluten fix needed is to remove the kblacklist and test it...
I'll do a comparison with spark to see if it is the case, but it should be a
trivial fix.
##########
cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc:
##########
@@ -60,7 +60,7 @@ const std::unordered_set<std::string> kRegexFunctions = {
"split"};
const std::unordered_set<std::string> kBlackList =
- {"split_part", "sequence", "approx_percentile", "map_from_arrays"};
+ {"split_part", "sequence", "map_from_arrays"};
Review Comment:
sure, I will look into it. @jinchengchenghh
https://github.com/facebookincubator/velox/pull/13183
I think that the velox part is compatible with spark as of 2025/05, it's
just for some reason the velox spark fix is not adopted in gluten. Right now I
think the only gluten fix needed is to remove the kblacklist and test it...
I'll do a comparison with spark to see if it is the case, but it should be a
trivial fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
