jinchengchenghh commented on code in PR #11830:
URL: https://github.com/apache/gluten/pull/11830#discussion_r2996270046
##########
cpp/velox/compute/VeloxBackend.cc:
##########
@@ -81,13 +92,20 @@ void veloxMemoryManagerReleaser(MemoryManager*
memoryManager) {
delete memoryManager;
}
-Runtime* veloxRuntimeFactory(
- const std::string& kind,
- MemoryManager* memoryManager,
- const std::unordered_map<std::string, std::string>& sessionConf) {
- auto* vmm = dynamic_cast<VeloxMemoryManager*>(memoryManager);
- GLUTEN_CHECK(vmm != nullptr, "Not a Velox memory manager");
- return new VeloxRuntime(kind, vmm, sessionConf);
+Runtime::Factory createVeloxRuntimeFactory(std::unordered_map<std::string,
std::string> immutableConf) {
+ return [immutableConf = std::move(immutableConf)](
+ const std::string& kind,
+ MemoryManager* memoryManager,
+ const std::unordered_map<std::string, std::string>& sessionConf)
-> Runtime* {
+ auto* vmm = dynamic_cast<VeloxMemoryManager*>(memoryManager);
Review Comment:
At this case, we need to set the config in java side to static to forbid
user setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
