jinchengchenghh commented on code in PR #11776:
URL: https://github.com/apache/gluten/pull/11776#discussion_r3027124245
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -755,4 +755,16 @@ object VeloxConfig extends ConfigRegistry {
.doc("Maps table field names to file field names using names, not
indices for Parquet files.")
.booleanConf
.createWithDefault(true)
+
+ val PARQUET_PAGE_SIZE_BYTES =
Review Comment:
Please remove the config, the config should not exposed to users, we should
respect iceberg corresponding config, in this case, please update the config
map as
https://github.com/apache/gluten/blob/main/backends-velox/src-iceberg/main/scala/org/apache/gluten/execution/AbstractIcebergWriteExec.scala#L37
Please find the codec path, and set to Velox config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
