jinchengchenghh commented on code in PR #11868:
URL: https://github.com/apache/gluten/pull/11868#discussion_r3027168327


##########
cpp/velox/compute/iceberg/IcebergWriter.cc:
##########
@@ -212,7 +221,47 @@ IcebergWriter::IcebergWriter(
 }
 
 void IcebergWriter::write(const VeloxColumnarBatch& batch) {
-  dataSink_->appendData(batch.getRowVector());
+  auto inputRowVector = batch.getRowVector();
+  auto inputRowType = asRowType(inputRowVector->type());
+  
+  // Filter columns to match the expected schema (rowType_)

Review Comment:
   And the metadata column name is the specific name, we only need to match the 
pattern to decide it is metadata column, could you show the example schema to 
let us understand this issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to