This is an automated email from the ASF dual-hosted git repository.
kejia pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 9b268b52d3 [GLUTEN-11888][VL]Remove the synchronized lock in
VeloxBroadcastBuildSideCache (#11834)
9b268b52d3 is described below
commit 9b268b52d342efc576f1b2fb0529b8d2e6a0c0e8
Author: JiaKe <[email protected]>
AuthorDate: Wed Apr 8 16:38:13 2026 +0100
[GLUTEN-11888][VL]Remove the synchronized lock in
VeloxBroadcastBuildSideCache (#11834)
---
.../gluten/execution/VeloxBroadcastBuildSideCache.scala | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git
a/backends-velox/src/main/scala/org/apache/gluten/execution/VeloxBroadcastBuildSideCache.scala
b/backends-velox/src/main/scala/org/apache/gluten/execution/VeloxBroadcastBuildSideCache.scala
index eadcb0f349..535fd8900e 100644
---
a/backends-velox/src/main/scala/org/apache/gluten/execution/VeloxBroadcastBuildSideCache.scala
+++
b/backends-velox/src/main/scala/org/apache/gluten/execution/VeloxBroadcastBuildSideCache.scala
@@ -57,7 +57,7 @@ object VeloxBroadcastBuildSideCache
def getOrBuildBroadcastHashTable(
broadcast: Broadcast[BuildSideRelation],
- broadcastContext: BroadcastHashJoinContext): BroadcastHashTable =
synchronized {
+ broadcastContext: BroadcastHashJoinContext): BroadcastHashTable = {
buildSideRelationCache
.get(
@@ -76,14 +76,13 @@ object VeloxBroadcastBuildSideCache
}
/** This is callback from c++ backend. */
- def get(broadcastHashtableId: String): Long =
- synchronized {
- Option(buildSideRelationCache.getIfPresent(broadcastHashtableId))
- .map(_.pointer)
- .getOrElse(0)
- }
+ def get(broadcastHashtableId: String): Long = {
+ Option(buildSideRelationCache.getIfPresent(broadcastHashtableId))
+ .map(_.pointer)
+ .getOrElse(0)
+ }
- def invalidateBroadcastHashtable(broadcastHashtableId: String): Unit =
synchronized {
+ def invalidateBroadcastHashtable(broadcastHashtableId: String): Unit = {
// Cleanup operations on the backend are idempotent.
buildSideRelationCache.invalidate(broadcastHashtableId)
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
