rui-mo commented on code in PR #11931: URL: https://github.com/apache/gluten/pull/11931#discussion_r3073677934
########## cpp/velox/substrait/SubstraitToVeloxPlan.cc: ########## @@ -1383,11 +1422,7 @@ core::PlanNodePtr SubstraitToVeloxPlanConverter::constructValueStreamNode( } // Create TableScanNode - auto tableScanNode = std::make_shared<core::TableScanNode>( - nodeId, - outputType, - tableHandle, - assignments); + auto tableScanNode = std::make_shared<core::TableScanNode>(nodeId, outputType, tableHandle, assignments); Review Comment: @zhouyuan The clang-format check in CI doesn’t seem to work correctly, as it didn’t report any formatting issues when the code was unformatted. Also, I’m using clang-format version 15.0.7 for formatting, but the results appear inconsistent. Do you have any input? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
