officialasishkumar commented on code in PR #11905:
URL: https://github.com/apache/gluten/pull/11905#discussion_r3077610658
##########
dev/builddeps-veloxbe.sh:
##########
@@ -120,15 +120,15 @@ do
shift # Remove argument name from processing
;;
--velox_repo=*)
- VELOX_REPO=("${arg#*=}")
+ VELOX_REPO="${arg#*=}"
Review Comment:
I checked the current script again, and I do not think we need the same
change for the other args in this PR. The scalar handling here matters for
`--velox_repo`, `--velox_branch`, and especially `--velox_home` because they
are reused when building `VELOX_PARAMETER` and when propagating `VELOX_HOME` to
child processes. The other flags are only consumed locally in this script
today. If there is another arg that also needs to cross that boundary, I can
handle it in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
