This is an automated email from the ASF dual-hosted git repository.
chengchengjin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gluten.git
The following commit(s) were added to refs/heads/main by this push:
new f9c090abdf [VL][UT] Enable two tests previously failing due to Velox
Expand operator bug (#11947)
f9c090abdf is described below
commit f9c090abdf54b5db2ed34b7d7bd5ae6bcd6012a8
Author: Philo He <[email protected]>
AuthorDate: Thu Apr 16 02:21:56 2026 -0700
[VL][UT] Enable two tests previously failing due to Velox Expand operator
bug (#11947)
What changes are proposed in this pull request?
Enable these two tests in
GlutenDeltaBasedUpdateAsDeleteAndInsertTableSuite. It covers Spark's
delta-based row update, which uses a row operation flag to mark deletes and
inserts. An Expand operator duplicates each row into two — one for delete and
one for insert. When updating a table with the WriteDelta operator, delete
records are filtered out based on the row operation flag.
For the delete flag marked row, NULL literal will be used to replace the
deprecated data, passing to Expand operators. Previously, the operator
incorrectly handles NULL literals of complex types, producing NULLs instead of
the expected values. This bug was fixed by Velox PR some months ago:
facebookincubator/velox#15684.
How was this patch tested?
Local test passed.
Was this patch authored or co-authored using generative AI tooling?
No.
---
.../test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | 3 ---
.../test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | 3 ---
.../test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | 3 ---
3 files changed, 9 deletions(-)
diff --git
a/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
b/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
index ed9f9ccfd9..c908bfe773 100644
---
a/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
+++
b/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
@@ -890,9 +890,6 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenDeltaBasedMergeIntoTableSuite]
enableSuite[GlutenDeltaBasedMergeIntoTableUpdateAsDeleteAndInsertSuite]
enableSuite[GlutenDeltaBasedUpdateAsDeleteAndInsertTableSuite]
- // FIXME: complex type result mismatch
- .exclude("update nested struct fields")
- .exclude("update char/varchar columns")
enableSuite[GlutenDeltaBasedUpdateTableSuite]
enableSuite[GlutenGroupBasedMergeIntoTableSuite]
enableSuite[GlutenFileSourceCustomMetadataStructSuite]
diff --git
a/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
b/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
index 3c557524ee..b6a19c61ff 100644
---
a/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
+++
b/gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
@@ -1116,9 +1116,6 @@ class VeloxTestSettings extends BackendTestSettings {
// Velox assert_not_null throws VeloxUserError instead of
SparkRuntimeException
.exclude("merge with NOT NULL checks")
enableSuite[GlutenDeltaBasedUpdateAsDeleteAndInsertTableSuite]
- // FIXME: complex type result mismatch
- .exclude("update nested struct fields")
- .exclude("update char/varchar columns")
// Velox assert_not_null throws VeloxUserError instead of
SparkRuntimeException
.exclude("update with NOT NULL checks")
enableSuite[GlutenDeltaBasedUpdateTableSuite]
diff --git
a/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
b/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
index 7cf5a28e01..968f28a6a9 100644
---
a/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
+++
b/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
@@ -1122,9 +1122,6 @@ class VeloxTestSettings extends BackendTestSettings {
// Velox assert_not_null throws VeloxUserError instead of
SparkRuntimeException
.exclude("merge with NOT NULL checks")
enableSuite[GlutenDeltaBasedUpdateAsDeleteAndInsertTableSuite]
- // FIXME: complex type result mismatch
- .exclude("update nested struct fields")
- .exclude("update char/varchar columns")
// Velox assert_not_null throws VeloxUserError instead of
SparkRuntimeException
.exclude("update with NOT NULL checks")
enableSuite[GlutenDeltaBasedUpdateTableSuite]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
