weiting-chen commented on PR #11854: URL: https://github.com/apache/gluten/pull/11854#issuecomment-4266601124
**Blocking dependency: Velox PR #16962 not yet merged** This PR depends on [facebookincubator/velox#16962](https://github.com/facebookincubator/velox/pull/16962) which is still open. Even after fixing the C++ compilation issue (see inline comment on VeloxConfig.h), the 4 un-excluded ANSI cast overflow tests will fail because the current Velox `isAnsiSupported()` returns `false` for numeric-to-integral casts. Please coordinate with Velox reviewers to get #16962 merged, then update Gluten's Velox pin before this PR can pass CI. Also: PR title is missing the required `[GLUTEN-XXXXX]` prefix per contribution guidelines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
