malinjawi commented on PR #11924: URL: https://github.com/apache/gluten/pull/11924#issuecomment-4282341471
> > @malinjawi have you checked whether the changes are covered by current Spark 4.0 CI? > > So the [commit](https://github.com/apache/gluten/commit/41a6fd83c1a65e863e436f31a5dc0a1a1a564c01) is included on this branch, but when I checked the logs it didn't seem to be running the UT added. Good catch @zhztheplayer. > > I will re-trigger the CI. Thanks for the catch @zhztheplayer — I checked this in detail. The current Spark 4.0 CI jobs (`spark-test-spark40` / `spark-test-spark40-slow`) run Maven without `-Pdelta`, so `src-delta40` Delta-profile tests are not picked up. Also, I noticed I forgot to commit my concrete Delta 4 suite classes. I’ll send a follow-up to add proper Delta 4 coverage ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
