Yao-MR commented on PR #11971:
URL: https://github.com/apache/gluten/pull/11971#issuecomment-4304525549
> @Yao-MR, thanks for the PR.
>
> Can we add this setting in pom.xml next to the following line for
simplicity? `<maven.compiler.release>${java.version}</maven.compiler.release>`
>
>
https://github.com/apache/gluten/blob/1ca995c17a64f5e38086dd8d599088177973882a/pom.xml#L63
> @Yao-MR, thanks for the PR.
>
> Can we add this setting in pom.xml next to the following line for
simplicity? `<maven.compiler.release>${java.version}</maven.compiler.release>`
>
>
https://github.com/apache/gluten/blob/1ca995c17a64f5e38086dd8d599088177973882a/pom.xml#L63
@philo-he
An alternative would be to set
<maven.compiler.release>17</maven.compiler.release> inside the java-17 profile
in the root pom.xml. That works for top-level invocations, but profile-level
properties are still overridable by command-line -D and by settings.xml
activeByDefault profiles on child modules, depending on activation order.
Pinning the value at the script's mvn invocation is the most deterministic
layer — it's where the "bundle build" contract is actually defined, and it
matches how the script already pins -Pjava-17 -Pscala-2.13 for the same reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
