zhztheplayer commented on code in PR #12001:
URL: https://github.com/apache/gluten/pull/12001#discussion_r3159599661
##########
cpp/CMakeLists.txt:
##########
@@ -66,6 +66,18 @@ if(NOT DEFINED VELOX_HOME)
message(STATUS "Set VELOX_HOME to ${VELOX_HOME}")
endif()
+if(NOT DEFINED VELOX_BUILD_PATH)
+ if(${CMAKE_BUILD_TYPE} STREQUAL "Debug")
+ set(VELOX_BUILD_PATH
+ "${VELOX_HOME}/_build/debug"
+ CACHE PATH "Velox build directory.")
+ else()
+ set(VELOX_BUILD_PATH
+ "${VELOX_HOME}/_build/release"
+ CACHE PATH "Velox build directory.")
+ endif()
+endif()
+
Review Comment:
Why we need to add this code in the root CMakeLists.txt? There is already
similar code in velox/CMakeLists.txt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
