liujiayi771 opened a new pull request, #12029:
URL: https://github.com/apache/gluten/pull/12029

   ## Summary
   
   `isPrimitiveType` in `VeloxValidatorApi` uses `dt.getClass.getSimpleName == 
"TimestampNTZType"` to check for TimestampNTZ type. However, `TimestampNTZType` 
is a Scala `case object`, so `getClass.getSimpleName` returns 
`"TimestampNTZType$"` (with a trailing `$`), causing the check to always fail. 
This means `validateSchema` rejects TimestampNTZ even when 
`enableTimestampNtzValidation` is set to `false`.
   
   **Fix:** Use `dt.catalogString == "timestamp_ntz"` instead, which is 
reliable regardless of how the type is defined in Scala.
   
   **Test:** Added a test in `VeloxParquetDataTypeValidationSuite` to verify 
that `validateSchema` correctly accepts/rejects TimestampNTZ based on the 
`enableTimestampNtzValidation` config.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to