malinjawi commented on code in PR #12024:
URL: https://github.com/apache/gluten/pull/12024#discussion_r3201849931
##########
backends-velox/src-delta33/main/scala/org/apache/spark/sql/execution/datasources/v2/OffloadDeltaCommand.scala:
##########
@@ -45,4 +50,20 @@ case class OffloadDeltaCommand() extends OffloadSingleNode {
case other => other
}
}
+
+ private def shouldOffloadOptimize(optimize: OptimizeTableCommand): Boolean =
{
+ optimize.zOrderBy.isEmpty &&
+ optimize.optimizeContext.reorg.isEmpty &&
+ !optimize.optimizeContext.isFull &&
+ !isClusteredOptimize(optimize)
+ }
Review Comment:
Yes, added a comment now to clarify that the offload check is intentionally
limited to the currently supported OPTIMIZE shape: plain bin-packing compaction
in this scope.
So OPTIMIZE variants with layout-specific semantics, such as ZORDER, REORG,
OPTIMIZE FULL, and liquid clustering, continue to use Delta’s original command
path until native support is added for those paths with later patches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
