zhztheplayer commented on code in PR #12049:
URL: https://github.com/apache/gluten/pull/12049#discussion_r3207767959
##########
gluten-core/src/main/scala/org/apache/gluten/extension/columnar/FallbackTag.scala:
##########
@@ -93,7 +93,13 @@ object FallbackTags {
case (exclusive: FallbackTag.Exclusive, _) =>
exclusive
case (l: FallbackTag.Appendable, r: FallbackTag.Appendable) =>
- FallbackTag.Appendable(s"${l.reason}; ${r.reason}")
+ if (l.reason == r.reason || l.reason.contains(r.reason)) {
+ l
+ } else if (r.reason.contains(l.reason)) {
+ r
+ } else {
+ FallbackTag.Appendable(s"${l.reason}; ${r.reason}")
+ }
Review Comment:
How about storing a hash set in `FallbackTag.Appendable`? Could be faster
and preciser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
