wForget commented on code in PR #12067:
URL: https://github.com/apache/gluten/pull/12067#discussion_r3231059518
##########
backends-velox/src/main/scala/org/apache/spark/shuffle/ColumnarShuffleWriter.scala:
##########
@@ -60,6 +60,14 @@ class ColumnarShuffleWriter[K, V](
private val blockManager = SparkEnv.get.blockManager
+ private val rowBasedChecksumEnabled: Boolean = {
+ try {
+ GlutenMapStatusUtil.isRowBasedChecksumEnabled
+ } catch {
+ case _: NoSuchMethodError | _: NoSuchFieldError => false
Review Comment:
We have created shim of `GlutenMapStatusUtil.isRowBasedChecksumEnabled`
method for each spark version. Do we still need to catch
NoSuchMethodError/NoSuchFieldError exceptions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
