minni31 commented on code in PR #12077: URL: https://github.com/apache/gluten/pull/12077#discussion_r3231676693
########## backends-velox/src/test/scala/org/apache/gluten/execution/VeloxRDDScanSuite.scala: ########## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution + +import org.apache.gluten.execution._ + +import org.apache.spark.SparkConf +import org.apache.spark.sql.Row +import org.apache.spark.sql.classic.ClassicDataset +import org.apache.spark.sql.execution.adaptive.AdaptiveSparkPlanHelper +import org.apache.spark.sql.types._ + +class VeloxRDDScanSuite extends VeloxWholeStageTransformerSuite with AdaptiveSparkPlanHelper { + + override protected val resourcePath: String = "/tpch-data-parquet" + override protected val fileFormat: String = "parquet" + + override protected def sparkConf: SparkConf = { + super.sparkConf + .set("spark.sql.ansi.enabled", "false") + } + + override def beforeAll(): Unit = { + super.beforeAll() + createTPCHNotNullTables() + } + + test("basic RDDScanExec is replaced by VeloxRDDScanTransformer") { + val data = spark.sql("SELECT l_orderkey, l_partkey FROM lineitem LIMIT 10") + val expectedAnswer = data.collect() + + val node = LogicalRDD.fromDataset( + rdd = data.queryExecution.toRdd, + originDataset = data, + isStreaming = false) + val df = ClassicDataset.ofRows(spark, node).toDF() + + checkAnswer(df, expectedAnswer) + val cnt = collect(df.queryExecution.executedPlan) { case _: VeloxRDDScanTransformer => true } + assert(cnt.nonEmpty, "Expected VeloxRDDScanTransformer in plan") + } + + test("RDDScan with string and numeric types") { + val data = spark.sql("""SELECT l_returnflag, l_linestatus, l_quantity, l_extendedprice + |FROM lineitem LIMIT 20""".stripMargin) + val expectedAnswer = data.collect() + + val node = LogicalRDD.fromDataset( + rdd = data.queryExecution.toRdd, + originDataset = data, + isStreaming = false) + val df = ClassicDataset.ofRows(spark, node).toDF() + + checkAnswer(df, expectedAnswer) + val cnt = collect(df.queryExecution.executedPlan) { case _: VeloxRDDScanTransformer => true } + assert(cnt.nonEmpty, "Expected VeloxRDDScanTransformer in plan") + } + + test("RDDScan with aggregation downstream") { + val query = + """SELECT l_returnflag, sum(l_quantity) AS sum_qty + |FROM lineitem + |WHERE l_shipdate <= date'1998-09-02' + |GROUP BY l_returnflag""".stripMargin + val data = spark.sql(query) + val expectedAnswer = data.collect() + + val node = LogicalRDD.fromDataset( + rdd = data.queryExecution.toRdd, + originDataset = data, + isStreaming = false) + val df = ClassicDataset.ofRows(spark, node).toDF() + + checkAnswer(df, expectedAnswer) Review Comment: You're right — tests 3–11 would silently pass even if offloading stopped working. Added collect { case _: VeloxRDDScanTransformer => true } assertions to all 8 tests that were missing them. The unsupported-type fallback test already asserts the absence of the transformer, so that one was fine as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
