philo-he commented on code in PR #12051:
URL: https://github.com/apache/gluten/pull/12051#discussion_r3239453109
##########
gluten-ut/spark40/src/test/scala/org/apache/spark/sql/sources/GlutenInsertSuite.scala:
##########
@@ -124,6 +124,25 @@ class GlutenInsertSuite
}
}
+ testGluten("storeAssignmentPolicy default ANSI is independent from ANSI
mode") {
+ withTable("store_assignment_ansi") {
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
+ assert(SQLConf.get.storeAssignmentPolicy ==
SQLConf.StoreAssignmentPolicy.ANSI)
+
+ spark.sql("CREATE TABLE store_assignment_ansi (c INT) USING PARQUET")
+ intercept[Exception] {
+ spark.sql("INSERT INTO store_assignment_ansi SELECT
'2147483648'").collect()
Review Comment:
Can we add a check for the exception message to confirm the expected
exception is thrown?
##########
gluten-ut/spark40/src/test/scala/org/apache/spark/sql/sources/GlutenInsertSuite.scala:
##########
@@ -124,6 +124,25 @@ class GlutenInsertSuite
}
}
+ testGluten("storeAssignmentPolicy default ANSI is independent from ANSI
mode") {
Review Comment:
This doesn't appear to be a variant of a Spark test. Can we move it to a new
suite under `backends-velox/`?
##########
cpp/velox/operators/functions/SparkCastModeSpecialForms.cc:
##########
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "operators/functions/SparkCastModeSpecialForms.h"
+
+#include "velox/expression/SpecialFormRegistry.h"
+#include "velox/functions/sparksql/specialforms/SparkCastExpr.h"
+#include "velox/functions/sparksql/specialforms/SparkCastHooks.h"
+
+namespace gluten {
+namespace {
+
+using namespace facebook::velox;
+using facebook::velox::functions::sparksql::SparkCastExpr;
+using facebook::velox::functions::sparksql::SparkCastHooks;
+
+bool isIntegralType(const TypePtr& type) {
+ return type == TINYINT() || type == SMALLINT() || type == INTEGER() ||
+ type == BIGINT();
+}
+
+bool isAnsiSupported(const TypePtr& fromType, const TypePtr& toType) {
Review Comment:
There's also a check on the Velox side. Will we maintain the ANSI support
check only here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
