malinjawi commented on PR #12040: URL: https://github.com/apache/gluten/pull/12040#issuecomment-4449798428
Addressed the Delta DV reader review comments in commit 905e6c894:\n\n- removed the native Delta protocol/version validation plumbing; Java-side Delta support gates DV handoff before native receives materialized payloads\n- added a connector-level native test that scans a file through the Delta connector with a materialized DV payload and verifies deleted row positions are filtered\n- documented expectedCardinality as an optional metadata-based corruption check for the deserialized DV bitmap\n\nLocal checks run: C++ format check for the touched files and git diff --check. I also attempted to configure/build velox_delta_read_test locally, but this checkout's available Velox dependency build was created without the Velox test libraries, so local compilation stopped before the target build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
