zhztheplayer commented on PR #11805: URL: https://github.com/apache/gluten/pull/11805#issuecomment-4479666444
Hi @baibaichen, there's some issue from my end working with this feature (especially the golden-generation script provided): 1. `mvnd` is platform-dependent - it's not usable on arm Linux: ``` ERROR: Failed to download mvnd from https://downloads.apache.org/maven/mvnd/1.0.3/maven-mvnd-1.0.3-linux-aarch64.tar.gz ``` 2. `SPARK_HOME=...` is too strict for end developers - one has to install multiple Spark versions locally somewhere just for making this feature work. My suggestion: 1. Make the script ./dev/run-scala-test.sh platform-independent, e.g., remove the usage of mvnd 2. Do not require `SPARK_HOME`, provided this feature targets multiple different Spark versions If my questions are valid for you, can we revert or disable this golden check until the issues are addressed? Since this check on CI blocks some of my ongoing work involving query plan changes, and I was unable to generate the golden files using the script locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
