yaooqinn opened a new pull request, #12121:
URL: https://github.com/apache/gluten/pull/12121

   ## What changes were proposed in this pull request?
   
   Fix and expand build/test instructions in `AGENTS.md` so AI coding agents 
(and humans skimming the file) get correct, working commands on first try.
   
   Key changes:
   - Use `./build/mvn` wrapper consistently instead of bare `mvn` (the wrapper 
handles Maven download + Spark/Scala profile interactions)
   - Fix the ClickHouse build script invocation path
   - Add the correct profile combination for running `gluten-ut` test suites: 
`-Pspark-ut -Pbackends-velox -Pspark-3.5 -Pscala-2.12`
   - Add a "Common Pitfalls" section covering: native bundle must be built 
before JVM tests, profile mismatches between modules, and the mandatory format 
check
   - Trim verbose tables (Spark/Scala matrix, table-format profiles, OS install 
snippets) and link out to `docs/get-started/Velox.md` and 
`docs/get-started/ClickHouse.md` for details — AGENTS.md should be an 
entry-point pointer, not a duplicate handbook
   
   ## Why are the changes needed?
   
   The original `AGENTS.md` had several commands that don't work as written 
(bare `mvn`, wrong CH script path, missing `-Pspark-ut` for tests), and grew 
long enough to bury the essentials. Agents following it as-is hit dependency 
resolution failures or test-collection errors.
   
   ## Does this PR introduce any user-facing change?
   
   No. Doc-only.
   
   ## How was this patch tested?
   
   Locally verified every referenced command/flag/profile against `pom.xml`, 
`dev/buildbundle-veloxbe.sh`, `dev/builddeps-veloxbe.sh`, `dev/package*.sh`, 
and `ep/build-clickhouse/src/build-clickhouse.sh`. Diff reviewed line-by-line.
   
   Generated-by: Claude Opus 4.7
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to