nookcreed commented on PR #12110: URL: https://github.com/apache/gluten/pull/12110#issuecomment-4549723683
> could we enable the disabled suite in spark41 with this change? > > https://github.com/apache/gluten/blob/b8c5711d672c40ef3cc0717646074fa1bdeac46e/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala#L705 The suite comment originally said "2 failures" for Spark 4.1 vs "1 failure" for Spark 4.0. The key insight is that those two numbers indicate two distinct root causes: - Failure A — present in both Spark 4.0 and 4.1, so it predates SPARK-53968 and is unrelated to allowPrecisionLoss/evalContext. It's whatever causes the suite to stay disabled in 4.0 today. - Failure B (4.1-only) — introduced by SPARK-53968, which embedded allowPrecisionLoss in evalContext at analysis time. This is exactly what GLUTEN-11917 fixes. This PR resolves Failure B. Failure A remains, which is why enabling the suite unconditionally caused CI to fail. The updated comment (// 1 failure remains after GLUTEN-11917 fix) documents this so the next contributor knows where things stand — they just need to identify and exclude Failure A, then the suite can be enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
