yaooqinn commented on PR #12142: URL: https://github.com/apache/gluten/pull/12142#issuecomment-4552555291
+1. Three-layer plumbing (`Sig[BitmapConstructAgg]` on all 3 shims + `supportedAggFuncs` entry + plan-shape assertion) follows the same shape as the existing `BloomFilterAgg` registration in this file, which is the right precedent here. Grounded the plan-shape test guard: `bitmap_bit_position` is registered in `gen-function-support-docs.py` (BitmapBitPosition -> bitmap_bit_position), so the inner expression won't silently fallback and mask a `bitmap_construct_agg` regression. Good defensive test shape. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
