malinjawi commented on code in PR #12131:
URL: https://github.com/apache/gluten/pull/12131#discussion_r3312839502
##########
cpp/velox/substrait/SubstraitToVeloxPlan.h:
##########
@@ -50,6 +51,9 @@ struct SplitInfo {
/// The metadata columns associated with partitioned table.
std::vector<std::unordered_map<std::string, std::string>> metadataColumns;
+ /// Optional externally provided deletion vector payloads aligned with
metadataColumns.
+ std::vector<std::optional<SplitPayloadBufferView>> deletionVectorPayloads;
+
Review Comment:
Addressed. I added `DeltaSplitInfo` on the Velox side and moved the Delta DV
split state there instead of keeping it on the generic split metadata path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
