philo-he commented on PR #12105: URL: https://github.com/apache/gluten/pull/12105#issuecomment-4557957648
@jackylee-ch, thanks for the PR. Two questions. Please check if they make sense. Thank you! 1) Should we move the Velox compilation option setting to the Velox code? I'd assume this issue also needs the fix when building Velox standalone, not just from the Gluten build. 2) Is it possible for users to set INSTALL_PREFIX to /usr/local when running setup-macos.sh? If that could cause issues, perhaps we should add a check to warn (or disallow) users from doing so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
