lifulong opened a new pull request, #12213:
URL: https://github.com/apache/gluten/pull/12213
…compatible with spark conf spark.sql.parquet.writeLegacyFormat
<!--
Thank you for submitting a pull request! Here are some tips:
1. For first-time contributors, please read our contributing guide:
https://github.com/apache/gluten/blob/main/CONTRIBUTING.md
2. If necessary, create a GitHub issue for discussion beforehand to avoid
duplicate work.
3. If the PR is specific to a single backend, include [VL] or [CH] in the PR
title to indicate the
Velox or ClickHouse backend, respectively.
4. If the PR is not ready for review, please mark it as a draft.
-->
## What changes are proposed in this pull request?
Support config spark.sql.parquet.writeLegacyFormat while use native write,
compatible with Vanilla spark.
Velox doesn’t expose any config to control how Parquet decimal columns are
actually written.
I have added this parameter via PR
https://github.com/facebookincubator/velox/pull/16941.
This feature is really useful when Spark or Flink reads Hive tables using
ParquetHiveSerDe defined in Hive CREATE TABLE statements, especially with older
Hive versions like 2.1.
With Velox’s current write logic, it decides whether to write decimals as
int or fixed_len_byte_array based on precision.
When write decimal use Int32/Int64 will cause Spark and Flink to throw
exceptions when reading those Hive tables.
Depends on https://github.com/facebookincubator/velox/pull/16941
<!--
Provide a clear and concise description of the changes introduced in this PR.
Ensure the PR description aligns with the code changes, especially after
updates.
If applicable, include "Fixes #<GitHub_Issue_ID>" to automatically close the
corresponding issue
when the PR is merged.
-->
## How was this patch tested?
test at our produce env
<!--
Describe how the changes were tested, if applicable.
Include new tests to validate the functionality, if necessary.
For UI-related changes, attach screenshots to demonstrate the updates.
-->
## Was this patch authored or co-authored using generative AI tooling?
co-authored with cursor
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
