Copilot commented on code in PR #12163:
URL: https://github.com/apache/gluten/pull/12163#discussion_r3361501059
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -111,11 +124,7 @@ WholeStageResultIterator::WholeStageResultIterator(
velox::core::PlanFragment planFragment{planNode,
velox::core::ExecutionStrategy::kUngrouped, 1, emptySet};
std::shared_ptr<velox::core::QueryCtx> queryCtx = createNewVeloxQueryCtx();
task_ = velox::exec::Task::create(
- fmt::format(
- "Gluten_Stage_{}_TID_{}_VTID_{}",
- std::to_string(taskInfo_.stageId),
- std::to_string(taskInfo_.taskId),
- std::to_string(taskInfo.vId)),
+ getVeloxTaskId(taskInfo_),
std::move(planFragment),
0,
Review Comment:
When Spark SQL execution id is available, getVeloxTaskId() returns the same
string for all tasks of the same query (e.g., "Gluten_Execution_123"). Passing
that directly to velox::exec::Task::create can cause duplicate task IDs within
an executor, which can break Velox task management/metrics and potentially
return an existing task instead of creating a new one. Make the Velox task id
unique per task (e.g., append vId/stage/taskAttempt) while keeping executionId
as a prefix for grouping/debugging.
##########
ep/build-velox/src/get-velox.sh:
##########
@@ -17,9 +17,9 @@
set -exu
CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd)
-VELOX_REPO=https://github.com/IBM/velox.git
-VELOX_BRANCH=dft-2026_06_04
-VELOX_ENHANCED_BRANCH=ibm-2026_06_04
+VELOX_REPO=https://github.com/JkSelf/velox.git
+VELOX_BRANCH=dft-2026_06_04-hashtable-cache
+VELOX_ENHANCED_BRANCH=ibm-2026_06_04-hashtable-cache
Review Comment:
The build script now defaults to cloning Velox from a personal fork
(JkSelf/velox). This reduces build reproducibility and introduces supply-chain
risk for anyone running the default build path. Defaults should point to an
agreed upstream (e.g., IBM/velox or facebookincubator/velox) and personal forks
should only be used via explicit --velox_repo/--velox_branch overrides or via
UPSTREAM_VELOX_PR_ID patching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
