Copilot commented on code in PR #12079:
URL: https://github.com/apache/gluten/pull/12079#discussion_r3366957559
##########
cpp-ch/local-engine/Parser/RelParsers/ReadRelParser.cpp:
##########
@@ -201,7 +201,7 @@ QueryPlanStepPtr
ReadRelParser::parseReadRelWithLocalFile(const substrait::ReadR
auto source = std::make_shared<SubstraitFileSource>(getContext(), header,
local_files);
auto source_pipe = Pipe(source);
auto source_step = std::make_unique<SubstraitFileSourceStep>(getContext(),
std::move(source_pipe), "substrait local files");
- if (format_settings.parquet.use_native_reader_v3 && !readRowIndex &&
onlyFlatType)
+ if (format_settings.parquet.use_native_reader_v3 && !readRowIndex)
source_step->setStepDescription("ParquetReaderV3");
Review Comment:
`onlyFlatType` is computed but no longer used after dropping the
`onlyFlatType` condition in the ParquetReaderV3 selection. This can trigger an
unused-variable build failure under common warning settings; remove the
variable (or use it) to keep compilation clean.
##########
cpp-ch/local-engine/Parser/scalar_function_parser/tupleElement.cpp:
##########
@@ -49,6 +49,10 @@ namespace local_engine
Int32 field_index = static_cast<Int32>(field.safeGet<Int32>() +
1); \
const auto * index_node = addColumnToActionsDAG(actions_dag,
std::make_shared<DB::DataTypeUInt32>(), field_index); \
parsed_args.emplace_back(index_node); \
+ if (substrait_func.output_type().has_list() \
+ && substrait_func.output_type().list().nullability() ==
substrait::Type_Nullability_NULLABILITY_NULLABLE \
+ && !parsed_args[0]->result_type->isNullable()) \
+ parsed_args[0] = toFunctionNode(actions_dag, "toNullable",
{parsed_args[0]}); \
Review Comment:
Typo in the exception message above: "sceond" should be "second".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
