zhztheplayer commented on code in PR #12269:
URL: https://github.com/apache/gluten/pull/12269#discussion_r3395426939
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxIteratorApi.scala:
##########
@@ -94,10 +94,33 @@ class VeloxIteratorApi extends IteratorApi with Logging {
val metadataColumns = partitionFiles
.map(
f => SparkShimLoader.getSparkShims.generateMetadataColumns(f,
metadataColumnNames).asJava)
- val otherMetadataColumns = partitionFiles
- .map(f =>
SparkShimLoader.getSparkShims.getOtherConstantMetadataColumnValues(f))
+ val (otherMetadataColumns, deltaReadOptions) =
+ DeltaSplitMetadataExtractor.normalize(partitionSchema.fields.length,
partitionFiles)
+ .getOrElse {
+ (
+ partitionFiles.map {
+ f =>
SparkShimLoader.getSparkShims.getOtherConstantMetadataColumnValues(f)
+ },
+ Seq.empty[DeltaFileReadOptions])
+ }
- setFileSchemaForLocalFiles(
+ val localFilesNode = if (deltaReadOptions.nonEmpty) {
+ DeltaLocalFilesBuilder.makeDeltaLocalFiles(
+ partitionIndex,
+ paths.asJava,
+ starts.asJava,
+ lengths.asJava,
+ fileSizes.asJava,
+ modificationTimes.asJava,
+ partitionColumns.map(_.asJava).asJava,
+ metadataColumns.asJava,
+ fileFormat,
+ locations.toList.asJava,
+ mapAsJavaMap(properties),
+ otherMetadataColumns.asJava,
+ deltaReadOptions.asJava
+ )
Review Comment:
Can we override `getSplitInfosFromPartitions` in `DeltaScanTransformer`
instead?
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -69,6 +73,51 @@ const std::string kWriteIOTime = "writeIOWallNanos";
// others
const std::string kHiveDefaultPartition = "__HIVE_DEFAULT_PARTITION__";
+const std::string kDeltaTableFormat = "delta";
+const std::string kTableFormatKey = "table_format";
Review Comment:
Do we need these?
I assume we can use `file.file_format_case()` from substrait proto API to
determine the file type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
