zhouyuan commented on code in PR #12302:
URL: https://github.com/apache/gluten/pull/12302#discussion_r3426230057
##########
cpp/core/compute/Runtime.h:
##########
@@ -189,6 +197,7 @@ class Runtime : public
std::enable_shared_from_this<Runtime> {
protected:
std::string kind_;
MemoryManager* memoryManager_;
+ ThreadManager* threadManager_;
Review Comment:
was trying to understand the lifetime for this `threadManager_`: initially
we run into some leakage from VeloxRuntime and we need to careful on destructor
maybe we could change this to unique_ptr so it will be released when runtime
destruct?
##########
backends-velox/src/test/java/org/apache/gluten/test/MockVeloxBackend.java:
##########
@@ -72,7 +73,8 @@ public Object ask(Object message) throws Exception {
private static SparkConf newSparkConf() {
final SparkConf conf = new SparkConf();
conf.set(GlutenConfig.SPARK_OFFHEAP_SIZE_KEY(), "1g");
- conf.set(VeloxConfig$.MODULE$.COLUMNAR_VELOX_CONNECTOR_IO_THREADS().key(),
"0");
+ conf.set(GlutenCoreConfig.NUM_TASK_SLOTS_PER_EXECUTOR().key(), "1");
Review Comment:
it seems this value is set to -1 on scala side
https://github.com/apache/gluten/blob/3b08a23683cf18fe34c04a99a0609c315c4d8c08/gluten-core/src/main/scala/org/apache/gluten/config/GlutenCoreConfig.scala#L173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
