Copilot commented on code in PR #12163: URL: https://github.com/apache/gluten/pull/12163#discussion_r3440054366
########## ep/build-velox/src/get-velox.sh: ########## @@ -17,9 +17,9 @@ set -exu CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd) -VELOX_REPO=https://github.com/IBM/velox.git -VELOX_BRANCH=dft-2026_06_12 -VELOX_ENHANCED_BRANCH=ibm-2026_06_12 +VELOX_REPO=https://github.com/JkSelf/velox.git +VELOX_BRANCH=dft-2026_06_12-hashtable-cache +VELOX_ENHANCED_BRANCH=ibm-2026_06_12-hashtable-cache Review Comment: `get-velox.sh` now defaults to cloning Velox from a personal fork (`JkSelf/velox`). This makes builds non-reproducible and introduces an avoidable supply-chain risk for anyone running the build scripts. Please keep the default pinned to an official upstream (e.g., the previous `IBM/velox` default) and use `--velox_repo/--velox_branch` or `UPSTREAM_VELOX_PR_ID` when testing forks/PR branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
