KevinyhZou commented on code in PR #12327:
URL: https://github.com/apache/gluten/pull/12327#discussion_r3456972203
##########
gluten-flink/runtime/src/main/java/org/apache/gluten/table/runtime/operators/GlutenOneInputOperator.java:
##########
@@ -238,16 +260,31 @@ public void processWatermark2(Watermark mark) throws
Exception {
@Override
public void close() throws Exception {
- if (task != null) {
- task.close();
- }
- if (inputQueue != null) {
- inputQueue.noMoreInput();
- inputQueue.close();
- }
- if (sessionResource != null) {
- sessionResource.close();
- }
+ GlutenCloseables.runWithCleanup(
+ () -> {
Review Comment:
`GlutenCloseables`.runWithCleanUp seems to flush the data in memory to
filesystem, but these data's offset may not submit to MQ, therefore, if the job
failover or restart, the data would be duplicated
##########
gluten-flink/ut/src/test/resources/nexmark/q10.sql:
##########
@@ -9,7 +9,7 @@ CREATE TABLE nexmark_q10 (
) PARTITIONED BY (dt, hm) WITH (
'connector' = 'filesystem',
'path' = 'file:///tmp/data/output/bid/',
- 'format' = 'csv',
+ 'format' = 'orc',
Review Comment:
may be we can add another sql `q10_orc` to test this? or change format value
in `NexmarkTest` to test this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
