felipepessoto commented on PR #12371: URL: https://github.com/apache/gluten/pull/12371#issuecomment-4803978436
@zhztheplayer @philo-he I re-created the PR, the previous one had so some Copilot comments because of all the updates I did that was impossible to follow. I'd like to answer the questions you posted: > Can we remove the duplicated tests in Gluten's codebase, if they are covered by the new way? A: I think it depends on the approach we agree to follow. If we are adding this as a manual Action or for every PR (the best, but expensive) > Is this job a duplicate of the one in velox_backend_x86.yml? If so, we might consider moving the Delta tests into that file to reuse the native artifact it builds, since that artifact can't be shared across different workflows. > > This is also a consideration for reducing our GHA usage, see https://github.com/apache/gluten/issues/12288 A: I think having a separate job makes easier to maintain. Everything in this PR is new and could be easily replaced if needed, also the Delta tests takes so long that the time to build native artifacts becomes relatively small. If you want, I don't mind to move it too. I'm concerned about the https://github.com/apache/gluten/issues/12288, ideally, we should increase the number of shards for Delta UT, to 8 or 16. Is waiting 3 hours for CI completion ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
