brijrajk commented on PR #12151: URL: https://github.com/apache/gluten/pull/12151#issuecomment-4806221659
### CI failure explanation — `spark-test-spark40` / `spark-test-spark41` The 3 failing checks (`spark-test-spark40` ×2, `spark-test-spark41`) are all caused by a **pre-existing** `GlutenTPCHPlanStabilitySuite` → `tpch/q19` failure, unrelated to this PR's bloom filter changes. **Root cause:** `GlutenPlanStabilitySuite.glutenNormalizeIds()` uses a regex that matches any `#<digits>` pattern — including TPC-H string literals. The `p_brand` filter in q19 uses values `Brand#11`, `Brand#12`, `Brand#13`. Over the 264 commits since the golden file was added in #11805 (2026-03-24), new optimizer rules shifted the ExprId counter so `Brand#12` now normalizes to `Brand#6`, causing a spurious plan mismatch. The suite code itself warns about this at line 67–68: > *"Running all suites together in one JVM is recommended to avoid ExprId normalization issues where string constants (e.g., Brand#23 in TPCH q19) may collide with ExprId numbers."* **Evidence this is pre-existing (not introduced by this PR):** Ran `GlutenTPCHPlanStabilitySuite` on `main` without this PR applied: ``` Tests: succeeded 21, failed 1 ← q19 fails on main too ``` This PR's bloom filter `injectOptimizerRule` does not affect q19 — the rule finds no `BloomFilterMightContain` in q19's plan and returns it unchanged. **Fix:** Opened #12374 to refresh the q19 golden file. Once that merges, these CI checks should go green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
