Copilot commented on code in PR #12384:
URL: https://github.com/apache/gluten/pull/12384#discussion_r3485573881
##########
dev/docker/Dockerfile.centos9-static-build:
##########
@@ -26,8 +26,7 @@ ENV VCPKG_BINARY_SOURCES=clear;files,${VCPKG_PATH},readwrite
RUN set -ex; \
yum update -y && yum install -y epel-release sudo dnf && yum install -y
ccache; \
- dnf install -y --setopt=install_weak_deps=False gcc-toolset-12
gcc-toolset-13 perl-FindBin; \
- pip install cmake==3.31.4; \
+ dnf install -y --setopt=install_weak_deps=False gcc-toolset-12
gcc-toolset-13 perl-FindBin cmake; \
Review Comment:
This change switches from a pinned CMake (`pip install cmake==...`) to the
distro `cmake` package. The repo’s RHEL-family setup scripts still assume CMake
>= 3.28.3 (e.g. `dev/vcpkg/setup-build-depends.sh` and
`ep/build-velox/src/setup-rhel.sh`), so relying on the distro package here
risks non-deterministic breakage if the Stream9 repo version is below that
minimum.
At a minimum, add an explicit version check to fail fast with a clear error
message (or keep using a pinned CMake install method).
##########
dev/vcpkg/setup-build-depends.sh:
##########
@@ -157,9 +157,6 @@ install_centos_8() {
pip3 install --upgrade pip
Review Comment:
In `install_centos_8()`, `pip3 install --upgrade pip` assumes `pip3` exists,
but the package list only installs `python3` (not `python3-pip`). On
CentOS/RHEL these are typically separate packages, so this step can fail.
Install `python3-pip` explicitly (or remove the `pip3` usage if it’s no
longer needed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
