brijrajk commented on PR #12374: URL: https://github.com/apache/gluten/pull/12374#issuecomment-4828412603
Closing — the q19 golden does not actually need refreshing. After further investigation, the q19 "failure" only reproduces when `GlutenTPCHPlanStabilitySuite` is run **in isolation**: the TPC-H string literals `Brand#11/12/13` collide with the `#N` ExprId normalizer in `glutenNormalizeIds`, and the normalized result depends on JVM-wide ExprId accumulation. CI runs the whole `gluten-ut/spark40` module in one JVM, where this does **not** reproduce — so `main`'s q19 golden is correct there. Confirmed by #12151 (which touches Velox backend Scala and therefore runs `spark-test-spark40` / `spark-test-spark41`): it is green with q19 left **identical to `main`**. This refresh would change q19 *away* from that CI-correct golden — which is exactly why this PR's own CI was red on q19. The underlying normalizer limitation is tracked in #12375; a static golden refresh can't fix it reliably anyway (the normalization is run-context dependent). Closing as not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
