brijrajk commented on issue #12375: URL: https://github.com/apache/gluten/issues/12375#issuecomment-4828412803
Correction after further investigation (see #12151): - The q19 golden is **not** stale in CI, and q19 does **not** fail for every Velox-backend-Scala PR. The mismatch only appears in **isolated** `GlutenTPCHPlanStabilitySuite` runs. CI runs the whole `gluten-ut/spark40` module in one JVM, where the `Brand#NN` ↔ ExprId collision does not reproduce. #12151 is green with q19 left identical to `main`, confirming the committed golden is correct in CI. - The "short-term fix" (#12374, golden refresh) has been **closed** — it deviates q19 from the CI-correct golden and a static golden can't reliably match CI's normalization anyway. The valid remaining scope of this issue is the **long-term fix only**: make `glutenNormalizeIds` not treat string literals such as `Brand#NN` as ExprIds, so plan-stability goldens are stable in isolated suite runs too. Keeping this open for that improvement (low priority — it does not block CI). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
