LuciferYang commented on PR #12442: URL: https://github.com/apache/gluten/pull/12442#issuecomment-4890372828
Yes. If this branch were hit, no transition would be inserted for a child whose `Convention` is `isNone`, so the failure would surface in the executor at `doExecute` / `doExecuteColumnar` (or codegen) time. The branch is not currently reachable in production, so this PR is a defense-in-depth cleanup rather than a fix for an observed failure. I updated the PR body to drop the overreaching wording. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
