ggjh-159 commented on code in PR #12428:
URL: https://github.com/apache/gluten/pull/12428#discussion_r3527714562
##########
gluten-flink/planner/src/main/java/org/apache/gluten/velox/FileSystemSinkFactory.java:
##########
@@ -134,9 +134,15 @@ public Transformation<RowData> buildVeloxSink(
"FileSystemInsertTable");
GlutenOneInputOperatorFactory<?, ?> operatorFactory =
new GlutenOneInputOperatorFactory(onewInputOperator);
+ // If rowtime transformation was applied (rowtimeFieldIndex != -1), a
native
+ // StreamRecordTimestampInserter sits at this position. Replace it with a
Gluten columnar
+ // inserter so the chain stays columnar end-to-end; otherwise this is a
no-op.
+ Transformation<RowData> veloxFileWriterInput =
+ GlutenRowtimeInserterHelper.processTransformation(
+ (Transformation<RowData>)
fileWriterTransformation.getInputs().get(0));
Review Comment:
Agreed. Updated `FileSystemSinkFactory` to call
`GlutenRowtimeInserterHelper.processTransformation(input,
/*requiresTimestamp=*/false)`, which removes any native
`StreamRecordTimestampInserter` from the input chain instead of replacing it
with the columnar one. Same treatment applied to `PrintSinkFactory` and
`FuzzerSourceSinkFactory`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
