brijrajk commented on PR #12151: URL: https://github.com/apache/gluten/pull/12151#issuecomment-4900336763
Hi @zhztheplayer — just following up on your June 29 question about the `ObjectHashAggregate` fallback in the q59 plan stability golden. To summarise: the fallback is intentional — `PlanSubqueries` (pos 2) prepares the subquery before `ApplyColumnarRulesAndInsertTransitions` (pos 10) runs, so `HeuristicTransform` sees vanilla `BloomFilterAggregate` and emits `ObjectHashAggregateExec`. `BloomFilterRuntimeFilterRewriteRule` then patches the inner function to `VeloxBloomFilterAggregate` at pos 10, so it produces version=1 bytes correctly. Substituting earlier would break the `SPARK-54336` empty-input NULL semantics. A regression test covering this exact scenario was added in `GlutenBloomFilterFallbackSuite`. Hope this helps address your concern! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
